Differential D28327

[Inotify] Start the MoveFrom expire timer at most once per inotify batch
ClosedPublic
Actions

Authored by bruns on Mar 26 2020, 11:47 PM.

Details

Reviewers
ngraham
Group Reviewers
Baloo
Commits
R293:1e7145ac06c0: [Inotify] Start the MoveFrom expire timer at most once per inotify batch
Summary

We may get several MoveFrom/MoveTo events per read. If we are lucky,
we get complete pairs for renames and the cookie list is empty, then
there is no need to start the timer at all.

Avoid indefinite process delays of unpaired MoveFrom events by new
MoveFrom events. Restart the timer only if not already active, and
process all events when a 1 second deadline has passed.

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Mar 26 2020, 11:47 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 26 2020, 11:47 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Mar 26 2020, 11:47 PM
ngraham accepted this revision.Mar 27 2020, 2:15 PM
This revision is now accepted and ready to land.Mar 27 2020, 2:15 PM
Closed by commit R293:1e7145ac06c0: [Inotify] Start the MoveFrom expire timer at most once per inotify batch (authored by bruns). · Explain WhyMar 27 2020, 4:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/file/kinotify.cpp (49 lines)

Diff 78677

View Options

src/file/kinotify.cpp

Loading...