Differential D28315

Rework file numbering
ClosedPublic
Actions

Authored by davidre on Mar 26 2020, 4:48 PM.

Details

Reviewers
ngraham
Group Reviewers
Spectacle
Commits
R166:a7466c699b7f: Rework file numbering
Summary

Previously we looped though every match and checked the filesystem every
iteration. Now we do it only once which should result in better performance. I
also added a test case that shows that the old method was broken, too.

Test Plan

run tests

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.Mar 26 2020, 4:48 PM
Restricted Application added a project: Spectacle. · View Herald TranscriptMar 26 2020, 4:48 PM
davidre requested review of this revision.Mar 26 2020, 4:48 PM
ngraham added a subscriber: ngraham.Mar 30 2020, 1:41 PM
ngraham added inline comments.
src/ExportManager.cpp
225

leftover?

tests/FilenameTest.cpp
85

ditto

davidre updated this revision to Diff 78896.Mar 30 2020, 1:43 PM

remove leftover qdebug

ngraham accepted this revision.Mar 30 2020, 1:43 PM
This revision is now accepted and ready to land.Mar 30 2020, 1:43 PM
Closed by commit R166:a7466c699b7f: Rework file numbering (authored by davidre). · Explain WhyMar 30 2020, 2:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ExportManager.cpp (43 lines)
Mtests/FilenameTest.cpp (30 lines)

Diff 78901

View Options

src/ExportManager.cpp

Loading...
View Options

tests/FilenameTest.cpp

Loading...