Differential D28311

[applets/systemtray] Clear item from shown/hidden list when disabling entry
ClosedPublic
Actions

Authored by nicolasfella on Mar 26 2020, 3:39 PM.

Details

Reviewers
kmaterka
broulik
Group Reviewers
Plasma
Commits
R120:fede85a3d0ea: [applets/systemtray] Clear item from shown/hidden list when disabling entry
Summary

Else the entry is still in cfg_shownItems/cfg_hiddenItems and the config UI will display it as shown instead of disabled.

BUG: 419197

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Mar 26 2020, 3:39 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 26 2020, 3:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Mar 26 2020, 3:39 PM
broulik accepted this revision.Mar 26 2020, 3:45 PM
broulik added a subscriber: broulik.
broulik added inline comments.
applets/systemtray/package/contents/ui/ConfigEntries.qml
232

Keep the order consistent with the cases above: shown, hidden, extra

This revision is now accepted and ready to land.Mar 26 2020, 3:45 PM
Closed by commit R120:fede85a3d0ea: [applets/systemtray] Clear item from shown/hidden list when disabling entry (authored by nicolasfella). · Explain WhyMar 26 2020, 3:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 78563

View Options

applets/systemtray/package/contents/ui/ConfigEntries.qml

Loading...