| cblack | |
| davidedmundson |
| VDG | |
| Plasma |
This patch fixes several errors in the code:
BUG: 417852
FIXED-IN: 5.18.4
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Your patch indeed makes the date behave like in previous releases again! However I noticed it's still not quite consistent in its behavior: when I start plasmashell freshly, the date is a lot wider than after resizing it to roughly the same width. I've added a new attachment, which hopefully explains what I'm trying to say.
Yeah, I've noticed that too. I haven't been able to figure out how to improve it. Where it decides to wrap is also not very deterministic.
While it's not completely consistent yet, it still's an improvement that reverts the recent regression. As such, I'm tempted to say LGTM.
Visually looks nice, but would wait on review from a more experienced Plasma person since this looks like it could potentially be problematic and indeterministic at a glance to me.
You probably still want the elide.
We have a word wrap on, so you'll only hit this elide option when the alternative is paint outside the area and just leak over other items in the system tray. That always looks rubbish.