Dolphin-SVN: code update
ClosedPublic
Actions

Authored by nikolaik on Mar 20 2020, 8:17 PM.

Details

Reviewers

meven
elvisangelaccio

Commits

R449:2833d015ffec: Dolphin-SVN: code update

Summary

Pointers initialized with 'nullptr' instead of '0'.
Moved to a modern Qt-way of connecting signals and slots without SIGNAL() and SLOT() macros.
Class SVNCommands renamed to SvnCommands for consistency with other class names.

Test Plan

Ensure everything is correct, try some basic actions.

Repository

R449 Plugins for Dolphin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nikolaik requested review of this revision.Mar 20 2020, 8:17 PM

nikolaik created this revision.

This revision is now accepted and ready to land.Mar 22 2020, 9:02 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			svn/fileviewsvnplugin.cpp (52 lines)
M			svn/svncommands.h (2 lines)
M			svn/svncommands.cpp (28 lines)
M			svn/svncommitdialog.cpp (3 lines)
M			svn/svnlogdialog.cpp (14 lines)