Hi,
Please use arc so we can have context.

It can be a good idea to explain that this signals are already connected in kmessagebox directly in DialogButtonsHelper otherwise we don't understand why you removed them.

Please add info in commit log.
Regards

you can change "int result = KMessageBox::createKMessageBox(" to QDialogButtonBox::StandardButton return = ...

@mlaurent Thanks for the feedback! I was aware the commit message wasn't great, but couldn't figure out exactly where the signals were being handled.

Really appreciate the guidance :)

are you fixing a specific bug with this that's already reporting in bugs.kde.org?
if so, we should make sure to resolve that bug.

@winterz Yes, its a reported bug:

https://bugs.kde.org/show_bug.cgi?id=410758

I've added the ID in the revision summary . Is that not enough?

In D28149#631220, @sjolly wrote:

@winterz Yes, its a reported bug:

https://bugs.kde.org/show_bug.cgi?id=410758

I've added the ID in the revision summary . Is that not enough?

My bad. I see that now.
Feel free to commit into the release/20.04 branch and then merge to master.

In D28149#631221, @winterz wrote:

In D28149#631220, @sjolly wrote:

@winterz Yes, its a reported bug:

https://bugs.kde.org/show_bug.cgi?id=410758

I've added the ID in the revision summary . Is that not enough?

My bad. I see that now.
Feel free to commit into the release/20.04 branch and then merge to master.

@winterz Can you help me with this?

A bit new to arc and phabricator :)

Will arc land do this directly?

as long as you have write access, I believe that should work fine.