[applets/systemtray] Fix expanded representation's internal margins
ClosedPublic

Authored by ngraham on Mar 17 2020, 3:59 AM.

Details

Summary

This is a pre-existing problem, but became much more visible with D27189 (thus exposing
one of the reasons why I like visually separating dissimilar elements so much).
Essentially the dialog's bottom and right margins were not being properly mirrored on
the top and left, leading to the applet's content view looking off-center. Various apps
were locally adding their own extra top margins to compensate for this, which can be
removed once this patch lands.

This patch fixes that by explicitly using the default dialog margins for those edges.

I will submit follow-up patches to fix applets that were adding extra padding that is
now unnecessary.

Test Plan

It was especially noticeable with D27160.

Before:

After:

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Mar 17 2020, 3:59 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 17 2020, 3:59 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 17 2020, 3:59 AM
cblack accepted this revision.Mar 17 2020, 4:36 AM
cblack added a subscriber: cblack.

LGTM both visually and codewise.

This revision is now accepted and ready to land.Mar 17 2020, 4:36 AM
This revision was automatically updated to reflect the committed changes.