Fix Defaults not being set properly in Breeze window decoration settings for 'Draw a circle around close button'
ClosedPublic

Authored by paulm on Mar 17 2020, 12:20 AM.

Details

Summary

This fixes a small bug in the Breeze window decoration settings where clicking on 'Defaults' did nothing to change 'Draw a circle around close button' . This patch now causes 'Draw a circle around close button' to default correctly.

Diff Detail

Repository
R31 Breeze
Lint
Lint Skipped
Unit
Unit Tests Skipped
paulm created this revision.Mar 17 2020, 12:20 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 17 2020, 12:20 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
paulm requested review of this revision.Mar 17 2020, 12:20 AM
hpereiradacosta accepted this revision.Mar 17 2020, 2:54 AM

Many thanks !

This revision is now accepted and ready to land.Mar 17 2020, 2:54 AM

Nice. Can we have an email address so the patch gets landed with correct authorship information?

paulm added a comment.Mar 17 2020, 3:46 AM

Nice. Can we have an email address so the patch gets landed with correct authorship information?

No problem:
Paul McAuley <kde@paulmcauley.com>

(surprised you don't get this with the submitted .patch file)

Nice. Can we have an email address so the patch gets landed with correct authorship information?

No problem:
Paul McAuley <kde@paulmcauley.com>

(surprised you don't get this with the submitted .patch file)

Yeah, Phab is kinda dumb like that. Actually I suspect it deliberately discards that information in a bid to try to get you use the arc command line tool, which preserves it. Oh well, no matter, we're moving to GitLab soon. :)

This revision was automatically updated to reflect the committed changes.