check for window existence
ClosedPublic
Actions

Authored by mart on Mar 16 2020, 9:48 AM.

Details

Reviewers

ahiemstra

Group Reviewers

Kirigami

Commits

R169:848b5a7345f9: check for window existence

Summary

not always after componentcompleted a window is already there.
if is not there, do the same check whenthe item eventually gets a window

Test Plan

doesn't crash

Repository

R169 Kirigami

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart requested review of this revision.Mar 16 2020, 9:48 AM

ahiemstra added a subscriber: ahiemstra.

ahiemstra added inline comments.

src/shadowedrectangle.cpp
178	Just a minor nitpick: Please move this to the end of the file so that the method order in the source matches that of the header.

This revision is now accepted and ready to land.Mar 16 2020, 9:58 AM

This revision was automatically updated to reflect the committed changes.

broulik added inline comments.

src/shadowedrectangle.h
161	Missing `override`

			Path	Packages
M			src/shadowedrectangle.h (2 lines)
M			src/shadowedrectangle.cpp (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	77708	4d84d3f		Mar 16 2020, 9:48 AM	★	★
Diff 2	77710	f1ac443	R169:848b5a7345f988f1a2af4b23a8aee747434c3c92	Mar 16 2020, 9:59 AM	★	★