filetypestest fails but it's not related to this change (fails on master
too).
Details
Details
- Reviewers
apol davidedmundson - Group Reviewers
Plasma
make && ctest
Diff Detail
Diff Detail
- Repository
- R126 KDE CLI Utilities
- Branch
- l-qregexp (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23606 Build 23624: arc lint + arc unit
| kstart/kstart.cpp | ||
|---|---|---|
| 184 | Wouldn't it be easier here to just do windowtitle.compare(info.name(), Qt::CaseInsensitive) and skip the regex? | |
| kstart/kstart.cpp | ||
|---|---|---|
| 184 | I thought about that, but looking at the code I found: void KStart::sendRule() {
KXMessages msg;
QString message;
if( !windowtitle.isEmpty() )
message += QStringLiteral("title=") + windowtitle + QStringLiteral("\ntitlematch=3\n"); // 3 = regexp matchwhich made me leave the regex in... | |