Port away from the query language to lambda using the new KApplicationTrader API.
Depends on D27953.
dfaure |
Plasma |
Port away from the query language to lambda using the new KApplicationTrader API.
Depends on D27953.
Tested by hand with several applications, still works as expected.
No Linters Available |
No Unit Test Coverage |
Buildable 23599 | |
Build 23617: arc lint + arc unit |
Cool to see KApplicationTrader being used :-)
runners/appstream/appstreamrunner.cpp | ||
---|---|---|
96 | Note that the original trader query used =~ which meant "case insensitive comparison". | |
102 | This test seems slow and unnecessary. |
runners/appstream/appstreamrunner.cpp | ||
---|---|---|
96 | Might have just chosen the wrong operator, it's part of the problem of using a weird ad-hoc language I guess. |
runners/appstream/appstreamrunner.cpp | ||
---|---|---|
102 | For symmetry I would have removed the "else" altogether, there are many other cases of if()+return above already, no need to do things differently here. |