Differential D27950

Assign an icon to action submenus
ClosedPublic
Actions

Authored by apol on Mar 9 2020, 4:21 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:3f69e6401e44: Assign an icon to action submenus
Summary

Currently, action submenus (X-KDE-Submenu) have no icons.
This patch makes it inherit the icon of the first action.
There will always be at least one action, since empty submenus are
eliminated earlier in the function.
If the icon of the first action is empty, it will gracefully revert to
old behavior (not having an icon).

Patch by Chloe Kudryavtsev <toast@toast.cafe>

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23475
Build 23493: arc lint + arc unit
apol created this revision.Mar 9 2020, 4:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 9 2020, 4:21 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Mar 9 2020, 4:21 PM
dfaure accepted this revision.Mar 21 2020, 11:54 AM
This revision is now accepted and ready to land.Mar 21 2020, 11:54 AM
Closed by commit R241:3f69e6401e44: Assign an icon to action submenus (authored by apol). · Explain WhyMar 21 2020, 1:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/kfileitemactions.cpp (1 line)

Diff 77295

View Options

src/widgets/kfileitemactions.cpp

Loading...