Differential D27933

Don't compile and link twice tokenizer.cpp
AbandonedPublic
Actions

Authored by jjazeix on Mar 8 2020, 3:59 PM.

Details

Reviewers
pino
kfunk
Group Reviewers
KDevelop
Summary

Try to fix https://build.kde.org/view/Failing/job/KDevelop/job/kdev-css/job/kf5-qt5%20WindowsMSVCQt5.14/

kdev4cssparser.lib(kdev4cssparser.dll) : error LNK2005: "public: __cdecl Css::Tokenizer::Tokenizer(class KDevPG::TokenStream *,class QString const &)" (??0Tokenizer@Css@@QEAA@PEAVTokenStream@KDevPG@@AEBVQString@@@Z) already defined in tokenizer.cpp.obj

tokenizer.cpp is both in the target kdev4cssparser and css-parser. It should be only on one.

Test Plan

I couldn't compile due to missing dependencies, neither on Linux or Windows so no test done :/
But looking at the issue, it should fix it.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
jjazeix created this revision.Mar 8 2020, 3:59 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMar 8 2020, 3:59 PM
jjazeix requested review of this revision.Mar 8 2020, 3:59 PM
jjazeix updated this revision to Diff 77220.Mar 8 2020, 4:17 PM
jjazeix planned changes to this revision.Mar 8 2020, 4:19 PM

Following https://cgit.kde.org/kdev-css.git/log/parser/CMakeLists.txt, it should fix Windows build and not fail Linux one

jjazeix requested review of this revision.Mar 8 2020, 4:47 PM

Revision Contents
Changeset List

PathPackages
Mparser/CMakeLists.txt (6 lines)

Diff 77220

View Options

parser/CMakeLists.txt

Loading...