Improve code block highlighting support
ClosedPublic

Authored by mwolff on Mar 6 2020, 10:59 AM.

Details

Summary

Support multiple code blocks in a single message and highlight
the chunks in-between as rich text with emoticons. Furthermore,
trimm the individual text and code blocks, as we now rely on
HTML divs to seperate the blocks visually. This will allow us
to experiment with background colors for code blocks in the
future too.

Diff Detail

Repository
R865 Ruqola
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mwolff requested review of this revision.Mar 6 2020, 10:59 AM
mwolff created this revision.
mwolff updated this revision to Diff 77086.Mar 6 2020, 11:20 AM

use <code> instead of css style with monospace font

mwolff planned changes to this revision.Mar 6 2020, 11:44 AM

this needs to go hand-in-hand with an improvement to the styling of quoted messages and thread context - that doesn't work properly anymore with this patch since you cannot wrap a block tag with <font>. generally, that's broken though independent of this patch, as prepending e.g. > to a multi-line message is also wrong

mwolff requested review of this revision.Mar 6 2020, 12:05 PM

fixed via the follow-up patch at https://phabricator.kde.org/D27891

dfaure accepted this revision.Mar 6 2020, 12:10 PM
This revision is now accepted and ready to land.Mar 6 2020, 12:10 PM
This revision was automatically updated to reflect the committed changes.