Differential D27884

[gmenu-dbusmenu-proxy] Pass action "target" in invocation
ClosedPublic
Actions

Authored by broulik on Mar 6 2020, 9:11 AM.

Details

Reviewers

apol

Group Reviewers

Plasma

Commits

R120:503bf4f3a542: [gmenu-dbusmenu-proxy] Pass action "target" in invocation

Summary

According to documentation [1] a menu item has a target attribute, which is "the parameter to pass when activating the action". Furthermore, the action "Activate" method specifies "If the action activation requires a parameter then this parameter must be given in the second parameter (av).".
Also implements a TODO in the code.

[1] https://wiki.gnome.org/Projects/GLib/GApplication/DBusAPI

CCBUG: 418385

Test Plan

5.18

Can change view modes in mediainfo-gui now
Can still change view modes in LibreOffice, Inkscape, Gimp
Can still toggle checkboxes in LibreOffice, Inkscape, Gimp, Shotwell
Can still invoke normal menu items (such as "Open") in LibreOffice, inkscape, Gimp, Shotwell

Diff Detail

Repository

R120 Plasma Workspace

Lint

Lint Skipped

Unit

Unit Tests Skipped

broulik created this revision.Mar 6 2020, 9:11 AM

Restricted Application added a project: Plasma. · View Herald TranscriptMar 6 2020, 9:11 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Mar 6 2020, 9:11 AM

apol accepted this revision.Mar 8 2020, 7:37 PM

This revision is now accepted and ready to land.Mar 8 2020, 7:37 PM

Closed by commit R120:503bf4f3a542: [gmenu-dbusmenu-proxy] Pass action "target" in invocation (authored by broulik). · Explain WhyMar 9 2020, 8:24 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			gmenu-dbusmenu-proxy/actions.h (2 lines)
M			gmenu-dbusmenu-proxy/actions.cpp (10 lines)
M			gmenu-dbusmenu-proxy/window.h (2 lines)
M			gmenu-dbusmenu-proxy/window.cpp (11 lines)