Add filter for plugins quicker search
QLineEdit was added to UI form, then after the text in this line has been modified by
the user - line emits an signal and displayed list is updated. The filter works
comparing strings from the beginning, and does nothing when filter string is empty
To test the feature Preferences -> Extentions -> Enter data to the edit line
BUG: 408312
Details
Details
- Reviewers
SGOrava
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Thank you for your contribution.
Our Gitlab instance was moved just recently (few days ago).
| src/lib/preferences/pluginsmanager.cpp | ||
|---|---|---|
| 55 | same here, I would keep a blank line after connect commands. | |
| 173 | Please do not delete the blank line, or lines which you do not WANT to delete. It is good to keep unrelated code intact. | |
| 246 | This checks only if the plugin name starts with given string which is insufficient for proper search. Using QString::contains() fits the criteria of "search" much more. Plus Always use {} for commands after the conditions. | |
| src/lib/preferences/pluginsmanager.h | ||
| 47 | In headers methods are sometimes divided by blank lines to indicate that they do different kind of job than the previous "group" of methods, it is good to keep those blanks and find a better place for the new entry (this is sometimes a challenge but it is worth it because it makes code more readable (at least for me)) | |
Comment Actions
To improve the qualitity of the git history, it is recommanded to have a title that explain that it does (for example Add filter to Preferences > Extensions) and add BUG: 408312 in the summary so that the bug report is automatically closed when this diff is merged.