Differential D27777

Fix clicking thumb-only delegate
ClosedPublic
Actions

Authored by leinir on Mar 2 2020, 9:38 AM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
Commits
R304:b9a1dd14800b: Fix clicking thumb-only delegate
Summary

This fixes a call to an attached property which only exists on the
delegate root, not the children.

BUG:418368

Test Plan

Switch to the thumbnail only view and click an item. Notice that without the patch the click is ignored (and produces error output on the console), and that with the patch it works.

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Mar 2 2020, 9:38 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 2 2020, 9:38 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
leinir requested review of this revision.Mar 2 2020, 9:38 AM
leinir edited the test plan for this revision. (Show Details)Mar 2 2020, 9:40 AM
leinir added reviewers: Frameworks, ngraham.
ngraham accepted this revision.Mar 4 2020, 6:22 PM
This revision is now accepted and ready to land.Mar 4 2020, 6:22 PM
Closed by commit R304:b9a1dd14800b: Fix clicking thumb-only delegate (authored by leinir). · Explain WhyMar 5 2020, 8:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76997

View Options

src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml

Loading...