Compose RELEASE_SERVICE_VERSION into palapeli version
ClosedPublic

Authored by aacid on Feb 29 2020, 11:57 PM.

Details

Summary

Palapeli version was increased to 2.1 "recently" and not so many changes have been done since them
so asserting the verison number is stuck in the past is a bit too much, but still having it move with
each new release is important for reproducibility of issues, etc. so compromise and append the version at the end

Diff Detail

Repository
R423 Palapeli
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Feb 29 2020, 11:57 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptFeb 29 2020, 11:57 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
aacid requested review of this revision.Feb 29 2020, 11:57 PM
aacid added a comment.Mar 1 2020, 11:07 PM

In a world were people update version numbers when they fix bugs, i may make sense.

The world we live in has proven that is not the case and that's why we need auto updating version numbers.

Cheers,

Albert

El diumenge, 1 de març de 2020, a les 23:52:07 CET, Ian Wadham va escriure:

Hi Albert,

Might it make sense to insert a “.0.” after the “2.1” in the hope that someone might come along and fix a bug or two in the gameplay, plus an explanatory comment about that?

The fixer should then bump that zero to indicate that bugs directly affecting end-users had been fixed in that version --- as opposed to the game having changes made to adapt to changing libraries, or receiving fixes to those library-caused changes, or even just being re-released unchanged or with some translation changes (which AFAIK can happen).

Ditto for other KDE Games: many no longer have maintainers.

Cheers,
Ian W.

> On 1 Mar 2020, at 10:57 am, Albert Astals Cid <noreply@phabricator.kde.org> wrote:
>
> View Revision
> aacid created this revision.
> Herald added a reviewer: KDE Games.
> Herald added a subscriber: kde-games-devel.
> aacid requested review of this revision.
>
> REVISION SUMMARY
> Palapeli version was increased to 2.1 "recently" and not so many changes have been done since them
> so asserting the verison number is stuck in the past is a bit too much, but still having it move with
> each new release is important for reproducibility of issues, etc. so compromise and append the version at the end
>
>
> REPOSITORY
> R423 Palapeli
>
> BRANCH
> master
>
> REVISION DETAIL
> https://phabricator.kde.org/D27748
>
> AFFECTED FILES
> CMakeLists.txt
> src/CMakeLists.txt
> src/main.cpp
>
> To: aacid, KDE Games
> Cc: kde-games-devel

This revision was not accepted when it landed; it landed in state Needs Review.Mar 15 2020, 5:38 PM
This revision was automatically updated to reflect the committed changes.