Add API to check whether a barcode is one- or two-dimensional
ClosedPublic

Authored by vkrause on Feb 28 2020, 8:55 PM.

Details

Summary

This matters for user code doing some more advanced layouting or size
computations, especially once we remove the hardcoded minimum sizes
in here for proper high dpi support.

Diff Detail

Repository
R280 Prison
Branch
arcpatch-D27730
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23690
Build 23708: arc lint + arc unit
vkrause created this revision.Feb 28 2020, 8:55 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 28 2020, 8:55 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Feb 28 2020, 8:55 PM
svuorela requested changes to this revision.Mar 4 2020, 6:37 PM

I'm not sure I like the implementation. The current AbstractBarcode can also be implemented, at least theoretically, by software providing other barcodes that forever reason isn't available here. I have at least done that for some PoC ports of other things.

I suggest instead having a
enum class BarcodeDimensions { 1d, 2d, 3d, 4d } ;
perhaps with better names, and then just a barcodeDimensions() method on AbstractBarcode that can be switched over.

This revision now requires changes to proceed.Mar 4 2020, 6:37 PM
vkrause updated this revision to Diff 77128.Mar 6 2020, 5:42 PM

Alternative implementation for the barcode dimension API.

svuorela accepted this revision.Mar 6 2020, 6:30 PM

thanks.

This revision is now accepted and ready to land.Mar 6 2020, 6:30 PM
vkrause updated this revision to Diff 77607.Mar 14 2020, 10:05 AM

Rebase and bump version number to 5.69.

This revision was automatically updated to reflect the committed changes.