Differential D27694

Don't recreate ImageDataItem texture unless needed
ClosedPublic
Actions

Authored by davidllewellynjones on Feb 27 2020, 9:04 AM.

Details

Reviewers
leinir
danders
pvuorela
Group Reviewers
Calligra: 3.0
Commits
R8:5a5f98658e7f: Don't recreate ImageDataItem texture unless needed
Summary

Submitting on behalf of Joona Petrell.

This change improves performance by only updating the image texture if the image data changes.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald TranscriptFeb 27 2020, 9:04 AM
davidllewellynjones requested review of this revision.Feb 27 2020, 9:04 AM
leinir accepted this revision.Feb 27 2020, 9:08 AM

That's a very good idea, yes, go for it! :)

This revision is now accepted and ready to land.Feb 27 2020, 9:08 AM
pvuorela accepted this revision.Feb 27 2020, 1:35 PM
pvuorela added a subscriber: pvuorela.

Looking good.

Closed by commit R8:5a5f98658e7f: Don't recreate ImageDataItem texture unless needed (authored by pvuorela). · Explain WhyFeb 27 2020, 1:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcomponents/ImageDataItem.cpp (13 lines)

Diff 76544

View Options

components/ImageDataItem.cpp

Loading...