Use correct connections for QQC2 controls
AcceptedPublic

Authored by davidedmundson on Feb 27 2020, 12:28 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Summary

We only want to trigger things on user actions, not on value changes

Test Plan

Opened KCM, used those two controls

Diff Detail

Repository
R119 Plasma Desktop
Branch
Plasma/5.18
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22984
Build 23002: arc lint + arc unit
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 27 2020, 12:28 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 27 2020, 12:28 AM
apol accepted this revision.Feb 27 2020, 1:17 AM
This revision is now accepted and ready to land.Feb 27 2020, 1:17 AM
broulik added inline comments.
kcms/nightcolor/package/contents/ui/main.qml
223

Change this to index (which is the signal argument). There's no guarantee that currentIndex will be updated at this point (it wasn't a while ago)