Remove extra top and bottom padding from dock widgets
Changes PlannedPublic

Authored by ngraham on Feb 26 2020, 8:07 PM.

Details

Summary

This extra padding was no big deal when using the current Breeze style, where scrollable
views float amorphously over the background with no clearly-defined edges, but becomes
highly noticeable in a bad way when moving towards enclosing views between single-pixel
lines, as for T11661. In this case, you want for the scrollview to touch the line.

Test Plan

(With D27669 also applied) Dolphin's Places panel, before:

After:

Doesn't look any worse without D27669 applied either.

Diff Detail

Repository
R31 Breeze
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22974
Build 22992: arc lint + arc unit
ngraham created this revision.Feb 26 2020, 8:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 26 2020, 8:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 26 2020, 8:07 PM
cblack added a comment.Mar 6 2020, 5:23 AM

This LGTM visually for Dolphin, but I'm not sure how this would look when there's actually content in the areas you're adjusting pixel metrics for.

Can you think of an example of where there would be? If there's content inside this margin, that seems wrong to me anyway.

ngraham planned changes to this revision.Mar 6 2020, 1:43 PM

Oh I see now, like this, when unlocked: