[emojier] Set minimum window height and width
ClosedPublic

Authored by filipf on Feb 26 2020, 2:50 PM.

Details

Summary

There are two problems right now with the emojier's window:

  • when shrinking the window a scrollbar is drawn *over* the category drawer's icons
  • the whole window can be shrunk to be only 1px wide and only several pixels tall

To solve both issues this patch sets a minimum height that is equal to the height of the category drawer's content, thereby removing the possibility of a scrollbar appearing. Minimum width is then set to be somewhat bigger than minimum height to account for monitor aspect ratios.

In practice this amounts to about 465x370 on a 1080p screen.

BUG: 418195
FIXED-IN: 5.18.3

Test Plan

Before:
Scrollbar overlapping icons


The window at its smallest size

After:
The window at its smallest size

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Feb 26 2020, 2:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 26 2020, 2:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Feb 26 2020, 2:50 PM
filipf edited the test plan for this revision. (Show Details)Feb 26 2020, 2:52 PM
filipf added reviewers: apol, Plasma, VDG.
ngraham accepted this revision.Feb 26 2020, 3:41 PM
ngraham added a subscriber: ngraham.

Stable branch

This revision is now accepted and ready to land.Feb 26 2020, 3:41 PM
apol accepted this revision.Feb 27 2020, 1:11 AM
This revision was automatically updated to reflect the committed changes.