With a special case to prefer common "16:10" over "8:5"
Details
Details
- Reviewers
romangg - Group Reviewers
VDG - Commits
- R104:62042a990525: feat(kcm): show resolution aspect ratio
Diff Detail
Diff Detail
- Repository
- R104 KScreen
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Nice tight implementation.
| kcm/output_model.cpp | ||
|---|---|---|
| 497 | It's a sentence. So there should be a full stop in the end. | |
Comment Actions
Out of scope for the patch, but it should also show the default resolution of the display. It's also important for choosing the right aspect ratio.
Comment Actions
Do you have an example in the wild where the "default resolution" should be something else than the one with highest pixel count?
Comment Actions
Projectors and VMs can be weird. We already have the concept of preferredMode, so adding an asterisk should be easy.
Comment Actions
Do you have an example? Name the product. I know it should be easy technically, but my question is if it makes sense.
A mode is a combination of resolution and refresh rate. So I could imagine there are products that prefer higher refresh rate over resolution. But if all available products out there prefer the highest pixel count there is no need for other indicators than the ordering of the list.