feat(kcm): show resolution aspect ratio

Authored by broulik on Feb 26 2020, 11:47 AM.



With a special case to prefer common "16:10" over "8:5"

Test Plan

Diff Detail

R104 KScreen
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 26 2020, 11:47 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 26 2020, 11:47 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 26 2020, 11:47 AM
romangg accepted this revision.Feb 26 2020, 12:00 PM
romangg retitled this revision from feat(kcm): Show resolution aspect ratio to feat(kcm): show resolution aspect ratio.

Nice tight implementation.


It's a sentence. So there should be a full stop in the end.

This revision is now accepted and ready to land.Feb 26 2020, 12:02 PM
This revision was automatically updated to reflect the committed changes.
apol added a subscriber: apol.Feb 26 2020, 1:49 PM

Out of scope for the patch, but it should also show the default resolution of the display. It's also important for choosing the right aspect ratio.

Do you have an example in the wild where the "default resolution" should be something else than the one with highest pixel count?

Projectors and VMs can be weird. We already have the concept of preferredMode, so adding an asterisk should be easy.

Do you have an example? Name the product. I know it should be easy technically, but my question is if it makes sense.

A mode is a combination of resolution and refresh rate. So I could imagine there are products that prefer higher refresh rate over resolution. But if all available products out there prefer the highest pixel count there is no need for other indicators than the ordering of the list.