The accuracy spin value for the alignment tab was not being saved.
This now saves that value when it is changed in the UI.
Details
Details
- Reviewers
mutlaqja
Before this change, set the accuracy spin in the alignment tab UI to a new value, exit ekos and kstars. Restart kstars and ekos. The new value will not be there.
With the change, same procedure, and now the new accuracy value is in place when kstars and ekos is restarted.
Diff Detail
Diff Detail
- Repository
- R321 KStars
- Branch
- save-solver-accuracy (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22944 Build 22962: arc lint + arc unit
Comment Actions
The accuracy was saved in startSolving... so it needs to be removed from there. Also, I think if we are to do it this way, i.e. to save in options immediately after change, then we should use something like Focus::syncSettings to save on the number of functions for each setting.
Comment Actions
I'm happy to drop this, or to fix it as you suggest. Let me know your preference and if you do recommend the change, which other parameters should be affected as well.
FWIW, I think the current implementation is not intuitive--I think people would expect the parameter to be saved even if align is not started.
I, for one, didn't understand this pre-condition, which is why I sent in the PR.
Now that I know, I can live without it, but there may be others who are also fooled. Why not store the change when it is made?
Are there other parameters in this tab or other tabs that also aren't stored right away?
Comment Actions
I think syncSettings like Focuser is the good long term solution and it is the intuitive one (saved as soon as you make the change). Before, I saved it on starting alignment, but then we moved setting to syncSetting but it never made it for Alignment, so if you can work on implementing this for the alignment module that would be great Hy!