| apol |
| Frameworks |
For KCM modules, clicking the "Help" button when khelpcenter isn't
installed should open the corresponding documentaion for that module
at docs.kde.org; for example with the Fonts KCM, the "&application="
part of the url should be "&application=kcontorl/fonts".
See D27518 for more details.
Thanks to ltoscano for fixing docs.kde.org to make "&application=kcontrol/<module name>"
actually resolve to the correct url path.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 22998 | |
| Build 23016: arc lint + arc unit |
I created D27615 first; then this one on top of it (optimising the code in a separate commit).
| src/util/urlhandler.cpp | ||
|---|---|---|
| 56 | I could be wrong, but this is exactly equivalent to the original code, i.e. it won't reach this unless helpcenter is empty and it's not a kde app... and I actually wanted to ask about this bit from the original code, what is it supposed to do? | |
| src/util/urlhandler.cpp | ||
|---|---|---|
| 56 | I guess it was in case it wasn't found. Maybe just change into an error saying "can't open the following help url %1" where %1 is the url | |
We can't add new dependencies to a tier1 framework, it would break the whole dependency system.
Just make it a qCWarning.
I opted for qDebug() for now, and will change once a logging category is set up for KGuiAddons.
| src/CMakeLists.txt | ||
|---|---|---|
| 33 ↗ | (On Diff #76474) | Remove this change too. Also ki18n. |