KConfig: Convert to SPDX license statements
ClosedPublic

Authored by cordlandwehr on Feb 23 2020, 3:03 PM.

Details

Summary

Convert license headers to SPDX statements and add
license files as required by REUSE specification.

Diff Detail

Repository
R237 KConfig
Branch
spdx
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24058
Build 24076: arc lint + arc unit
cordlandwehr created this revision.Feb 23 2020, 3:03 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 23 2020, 3:03 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cordlandwehr requested review of this revision.Feb 23 2020, 3:03 PM
cgiboudeaux added inline comments.
src/core/kconfigbackend_p.h
6

I don't think this is useful

src/core/kconfigini_p.h
6–7

same thing here

src/kconfig_compiler/kcfg.xsd
32

What makes you think it's BSD?

src/kreadconfig/kwriteconfig.cpp
7–8

These 2 lines are only explanations about the 2 copyright holders listed above. They shouldn't be modified

cordlandwehr marked 3 inline comments as done.Feb 25 2020, 6:00 PM
cordlandwehr added inline comments.
src/kconfig_compiler/kcfg.xsd
32

Actually, I though quite a time about this and at the end did a comparison of the permissions specifically provided by this statement: use, copy and modify (yet there is no explicit statement of sublicensing and combining with other works). That -- in my understanding -- is the legal equivalent to the BSD-2 clause. However, the statement is quite different than the usual BSD 2 Clauses. but I am not aware of any license that is phrased in exactly this statement.

What is your opinion? Otherwise, I would also be fine with omitting it from the change for now and I could contact the authors if they agree and then do this change atomically later.

Better handling of explenatory texts

ognarb added a subscriber: ognarb.Feb 25 2020, 6:05 PM
ognarb added inline comments.
src/kconfig_compiler/kcfg.xsd
32

Searching in google, this looks like a standard license text for dtd files.

Reverting DTD license change

cordlandwehr marked 3 inline comments as done.Feb 29 2020, 10:44 AM

Reverted license change for the XSD file. Right now I do not see any equivalent in the SPDX registry.

This revision is now accepted and ready to land.Sat, Mar 21, 8:50 PM

Merge branch 'master' into spdx