Differential D27590

Calculate needsSave on checkbox toggle not on change
ClosedPublic
Actions

Authored by davidedmundson on Feb 22 2020, 10:45 PM.

Details

Reviewers
apol
ngraham
Group Reviewers
Plasma
Commits
R119:1dd4668f1bf1: Calculate needsSave on checkbox toggle not on change
Summary

Otherwise we will trigger it during load, which is wasteful.

But worse potentially we haven't evaluated the other settings yet, so it
could trigger that we have changed the settings, and prematurely set
apply to enabled prematurely which currently breaks things.

I suspect it will fix the bug below, I couldn't reproduce reliably
enough to prove it.

Please reopen if it remains an issue

BUG: 411584
Fixed-in: 5.18.2

Test Plan

Opened KCM
toggling still worked as expected

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 22 2020, 10:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 22 2020, 10:45 PM
apol accepted this revision.Feb 23 2020, 12:51 AM
apol added a subscriber: apol.

Makes sense

This revision is now accepted and ready to land.Feb 23 2020, 12:51 AM
ngraham accepted this revision.Feb 23 2020, 4:39 PM
Closed by commit R119:1dd4668f1bf1: Calculate needsSave on checkbox toggle not on change (authored by davidedmundson). · Explain WhyFeb 24 2020, 9:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76271

View Options

kcms/nightcolor/package/contents/ui/main.qml

Loading...