Differential D27578

IncidenceEditor: don't save the last used calendar if the user rejects the dialog
AbandonedPublic
Actions

Authored by winterz on Feb 22 2020, 3:02 PM.

Details

Reviewers
vkrause
dvratil
mlaurent
Summary

This patch prevents the calendar collection from being saved into the config file if the user rejects the dialog.
increases the probability that a useful value is saved/restored.

Test Plan

open dialog. notice pre-selected calendar is "foo". select a different calendar "bar". cancel dialog.
open dialog. notice that the pre-selected calendar is still "foo"

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
winterz created this revision.Feb 22 2020, 3:02 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 22 2020, 3:02 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
winterz requested review of this revision.Feb 22 2020, 3:02 PM
winterz added a comment.Feb 23 2020, 4:37 PM

I may abandon this.
I may decide that the lastUsedCalendar is useless and dump it completely. still thinking about it.

dvratil accepted this revision.Feb 24 2020, 3:06 PM
This revision is now accepted and ready to land.Feb 24 2020, 3:06 PM
winterz abandoned this revision.Mar 5 2020, 3:02 PM

I'm abandoning this patch because I'm planning to remove all traces of the "last calendar" config

Revision Contents
Changeset List

PathPackages
Msrc/incidencedialog.cpp (13 lines)

Diff 76177

View Options

src/incidencedialog.cpp

Loading...