Differential D27529

[applets/weather] Remove outdated extra configure button
ClosedPublic
Actions

Authored by davidedmundson on Feb 20 2020, 7:00 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R114:2c7737f8fe8d: [applets/weather] Remove outdated extra configure button
Summary

The containment seems to care for it correctly now

Also the old code was wrong and used anchors on an item inside a layout

BUG: 412114

Test Plan

New applet with no configuration
Saw a configure button in the middle still (instead of two)
Clicking it worked

Diff Detail

Repository
R114 Plasma Addons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22725
Build 22743: arc lint + arc unit
davidedmundson created this revision.Feb 20 2020, 7:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 20 2020, 7:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 20 2020, 7:00 PM
ngraham added a subscriber: ngraham.Feb 20 2020, 7:17 PM

Comic strip widget is also affected. If you fix both in this patch, it will resolve 412114. :)

davidedmundson updated this revision to Diff 76067.Feb 20 2020, 7:37 PM

include comics

davidedmundson edited the summary of this revision. (Show Details)Feb 20 2020, 7:45 PM
ngraham accepted this revision.Feb 20 2020, 7:52 PM

Stable branch?

This revision is now accepted and ready to land.Feb 20 2020, 7:52 PM
Closed by commit R114:2c7737f8fe8d: [applets/weather] Remove outdated extra configure button (authored by davidedmundson). · Explain WhyFeb 24 2020, 9:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76066

View Options

applets/weather/package/contents/ui/FullRepresentation.qml

Loading...