Differential D2751

Fix interaction between decoration and fullscreen ShellClient
ClosedPublic
Actions

Authored by graesslin on Sep 12 2016, 12:45 PM.

Details

Reviewers
sebas
bshah
Group Reviewers
Plasma on Wayland
KWin
Commits
R108:ded90756fbb7: Fix interaction between decoration and fullscreen ShellClient
Summary

A fullscreen ShellClient still had a decoration which was caused by
a combination of two bugs:

  • when going to/from fullscreen the decoration was not update
  • noBorder did not return true for a fullscreen window

Comparing to X11 Client both is done. So ShellClient needs to do the
same. This ensures that the correct geometry is requested when going
to fullscreen.

BUG: 366764

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 6655.Sep 12 2016, 12:45 PM
graesslin retitled this revision from to Fix interaction between decoration and fullscreen ShellClient.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland, bshah.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptSep 12 2016, 12:45 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
graesslin updated this revision to Diff 6662.Sep 12 2016, 1:58 PM
  • Added a RequestGeometryBlocker for going to fullscreen
  • changing maximize is ignored for wl_shell if ShellClient is fullscreen
graesslin updated this revision to Diff 6663.Sep 12 2016, 3:12 PM

Added another test case which goes normal -> maximized -> fullscreen

The test exposes a problem with decorated maximized windows. An incorrect
client side is requested on restore.

bshah edited edge metadata.Sep 12 2016, 3:26 PM

mmm.. still konsole is not fullscreen. :-\ panel still visible.

graesslin added a comment.Sep 13 2016, 6:40 AM
In D2751#51203, @bshah wrote:

mmm.. still konsole is not fullscreen. :-\ panel still visible.

somehow I think the stacking order is not getting adjusted. Another test case with a panel is needed.

graesslin added a comment.Sep 13 2016, 8:32 AM
In D2751#51314, @graesslin wrote:
In D2751#51203, @bshah wrote:

mmm.. still konsole is not fullscreen. :-\ panel still visible.

somehow I think the stacking order is not getting adjusted. Another test case with a panel is needed.

And yes the layer doesn't get updated, see http://commits.kde.org/kwin/95f506ad7d94d9179c1f6a259fa642b02bb8a0e0

graesslin added a comment.Sep 13 2016, 8:35 AM
In D2751#51332, @graesslin wrote:
In D2751#51314, @graesslin wrote:
In D2751#51203, @bshah wrote:

mmm.. still konsole is not fullscreen. :-\ panel still visible.

somehow I think the stacking order is not getting adjusted. Another test case with a panel is needed.

And yes the layer doesn't get updated, see http://commits.kde.org/kwin/95f506ad7d94d9179c1f6a259fa642b02bb8a0e0

And addressed with D2758

sebas accepted this revision.Sep 13 2016, 3:39 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Sep 13 2016, 3:39 PM
bshah accepted this revision.Sep 14 2016, 5:32 AM
bshah edited edge metadata.
Closed by commit R108:ded90756fbb7: Fix interaction between decoration and fullscreen ShellClient (authored by graesslin). · Explain WhySep 14 2016, 9:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6719

View Options

autotests/integration/shell_client_test.cpp

Loading...
View Options

shell_client.cpp

Loading...