Differential D2748

[effects] Repaint expandedGeometry in HighlightWindowsEffect
ClosedPublic
Actions

Authored by graesslin on Sep 12 2016, 9:16 AM.

Details

Reviewers
sebas
Group Reviewers
Plasma
KWin
Commits
R108:d910217bb974: [effects] Repaint expandedGeometry in HighlightWindowsEffect
Summary

The highlight windows effect tried to trigger repaints with the shadow
included by having an hardcoded pixel offset. This of course breaks if
the shadow is larger than the hardcoded value.

The reason presented on why it was done like that is no longer true and
in the effects the actual visible area including decorations and shadows
is available through the expandedGeometry.

BUG: 368495

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 6638.Sep 12 2016, 9:16 AM
graesslin retitled this revision from to [effects] Repaint expandedGeometry in HighlightWindowsEffect.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptSep 12 2016, 9:16 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
sebas accepted this revision.Sep 13 2016, 3:38 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Sep 13 2016, 3:38 PM
Closed by commit R108:d910217bb974: [effects] Repaint expandedGeometry in HighlightWindowsEffect (authored by graesslin). · Explain WhySep 14 2016, 9:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6718

View Options

effects/highlightwindow/highlightwindow.cpp

Loading...