Differential D27468

Don't double delete CommentsModel
ClosedPublic
Actions

Authored by davidedmundson on Feb 17 2020, 11:31 PM.

Details

Reviewers
leinir
Commits
R304:5c7ee50bf900: Don't double delete CommentsModel
Summary

CommentsModel instances are owned by the engine.

They are fetched through a getter with a cache, so ownership has to stay
that way.

QuickItemsModel should not be deleting them.

BUG: 417802

Test Plan

Got a valgrind log of the crash, which showed the issue
(see attached bug report)

Afterwards:
Opened systemsettings, opened comments dialog
Closed systemsettings

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 17 2020, 11:31 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 17 2020, 11:31 PM
leinir accepted this revision.Feb 18 2020, 8:39 AM
leinir added a subscriber: leinir.

Quite right. Looks like some leftovers from before that caching was added, shippit :)

This revision is now accepted and ready to land.Feb 18 2020, 8:39 AM
Closed by commit R304:5c7ee50bf900: Don't double delete CommentsModel (authored by davidedmundson). · Explain WhyFeb 18 2020, 8:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qtquick/quickitemsmodel.cpp (1 line)

Diff 75886

View Options

src/qtquick/quickitemsmodel.cpp

Loading...