Differential D2745

Don't bind ShellClient::acceptsFocus to whether the window is shown
ClosedPublic
Actions

Authored by graesslin on Sep 12 2016, 9:05 AM.

Details

Reviewers
bshah
Group Reviewers
Plasma on Wayland
KWin
Commits
R108:9b32615ab4d5: Don't bind ShellClient::acceptsFocus to whether the window is shown
Summary

A not shown window may accept focus (e.g. when minimized). Given that
the condition was wrong and broke when making minimized windows not
shown.

This change takes the idea of not passing focus to a closing or unmapped
window directly into acceptsFocus. Which also means that this condition
now works for xdg_shell windows.

BUG: 368673

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 6635.Sep 12 2016, 9:05 AM
graesslin retitled this revision from to Don't bind ShellClient::acceptsFocus to whether the window is shown.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland, bshah.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptSep 12 2016, 9:05 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
bshah accepted this revision.Sep 12 2016, 9:08 AM
bshah edited edge metadata.
This revision is now accepted and ready to land.Sep 12 2016, 9:08 AM
Closed by commit R108:9b32615ab4d5: Don't bind ShellClient::acceptsFocus to whether the window is shown (authored by graesslin). · Explain WhySep 12 2016, 11:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6645

View Options

autotests/integration/shell_client_test.cpp

Loading...
View Options

shell_client.cpp

Loading...