Re-enable auto-reconnect, after fixing logout.
ClosedPublic
Actions

Authored by dfaure on Feb 13 2020, 11:00 PM.

Details

Reviewers

mlaurent
kfunk

Commits

R865:157baeae33a8: Re-enable auto-reconnect, after fixing logout.

Summary

Disconnect websocket in ~DDPClient to avoid auto-reconnect
Make logout actually work by returning true in canStart() (obvious typo)

Also, don't clear the password on logout. I want to be able to log in again
without having to type the password again. No idea why this clear() was
there.

Cleanups: remove unused signal logoutDone() and unimplemented method DDPClient::logOut

Test Plan

Logout stays on login page, with password filled in.
Disconnecting from WIFI for a few minutes and then connecting again leads to the server
throwing us out, and ruqola reconnects.

Diff Detail

Repository

R865 Ruqola

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22453
Build 22471: arc lint + arc unit

dfaure requested review of this revision.Feb 13 2020, 11:00 PM

dfaure created this revision.

Harbormaster completed remote builds in B22453: Diff 75648.Feb 13 2020, 11:00 PM

Looks good to me, but didn't test.

This revision is now accepted and ready to land.Feb 14 2020, 7:45 AM

mlaurent accepted this revision.Feb 14 2020, 8:13 AM

Closed by commit R865:157baeae33a8: Re-enable auto-reconnect, after fixing logout. (authored by dfaure). · Explain WhyFeb 14 2020, 8:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/core/ddpapi/ddpclient.h (5 lines)
M			src/core/ddpapi/ddpclient.cpp (1 line)
M			src/core/rocketchataccount.cpp (3 lines)
M			src/core/rocketchataccountsettings.cpp (1 line)
M			src/rocketchatrestapi-qt5/authentication/logoutjob.cpp (4 lines)
M			src/rocketchatrestapi-qt5/restapiabstractjob.cpp (2 lines)
M			src/rocketchatrestapi-qt5/restapirequest.h (1 line)
M			src/rocketchatrestapi-qt5/restapirequest.cpp (1 line)