Set toolbox to invisble when it's invisible
ClosedPublic

Authored by davidedmundson on Thu, Feb 13, 10:37 PM.

Details

Summary

opacity was bound to editMode, but this did not affect visibility or
enabled.

Not only is this somewhat wasteful, enabled is very important as
otherwise shortcuts for buttons get intercepted to match the accelerator
applied to the internal buttons. This breaks all the multi-key shortcuts
that plasma uses as alt+d gets taken.

BUG: 416695
FIXED-IN: 5.18.1

Test Plan

Mad gammaray skillz to find the bug

Checked alt+d, a now opens the widget explorer
Checked edit mode through the context menu still showed the toolbox

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Feb 13, 10:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Thu, Feb 13, 10:37 PM
ngraham accepted this revision.Thu, Feb 13, 10:54 PM
ngraham added a subscriber: ngraham.

Nice find! Fixes the bug and makes sense to me.

This revision is now accepted and ready to land.Thu, Feb 13, 10:54 PM
This revision was automatically updated to reflect the committed changes.