Set toolbox to invisble when it's invisible

Authored by davidedmundson on Feb 13 2020, 10:37 PM.



opacity was bound to editMode, but this did not affect visibility or

Not only is this somewhat wasteful, enabled is very important as
otherwise shortcuts for buttons get intercepted to match the accelerator
applied to the internal buttons. This breaks all the multi-key shortcuts
that plasma uses as alt+d gets taken.

BUG: 416695
FIXED-IN: 5.18.1

Test Plan

Mad gammaray skillz to find the bug

Checked alt+d, a now opens the widget explorer
Checked edit mode through the context menu still showed the toolbox

Diff Detail

R119 Plasma Desktop
No Linters Available
No Unit Test Coverage
Build Status
Buildable 22452
Build 22470: arc lint + arc unit
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 13 2020, 10:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 13 2020, 10:37 PM
ngraham accepted this revision.Feb 13 2020, 10:54 PM
ngraham added a subscriber: ngraham.

Nice find! Fixes the bug and makes sense to me.

This revision is now accepted and ready to land.Feb 13 2020, 10:54 PM
This revision was automatically updated to reflect the committed changes.