Convert license statements to SPDX markers and
add license files as required by REUSE specification.
Details
- Reviewers
winterz - Maniphest Tasks
- T11550: Add SPDX License markers
- Commits
- R175:1bc908a8cfea: KHolidays: Convert license statements to SPDX expressions
Diff Detail
- Repository
- R175 KHolidays
- Branch
- spdx
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22510 Build 22528: arc lint + arc unit
src/holidayregion.cpp | ||
---|---|---|
31 ↗ | (On Diff #75594) | I don't think it should be changed here |
src/lunarphase.cpp | ||
6 ↗ | (On Diff #75594) | This looks suspicious @winterz ? |
src/parsers/plan2/holidayparserdriverplan.cpp | ||
6–13 ↗ | (On Diff #75594) | The original text lacks clarity. Are these file contributors or copyright holders? @winterz |
15 ↗ | (On Diff #75594) | why is "by" needed here? |
src/parsers/plan2/holidayparserplan.ypp | ||
3–10 ↗ | (On Diff #75594) | same question for this file |
src/parsers/plan2/holidayscannerplan.cpp | ||
1297–1301 ↗ | (On Diff #75594) | and these lines were not updated |
src/parsers/qcalendarsystem.cpp | ||
833 ↗ | (On Diff #75594) | also looks wrong |
Clarified several statements
- Recovered origin of weekNumber method and its original license
- Unified verbose license statements
- Clarified snippet licensing
Updated several statements, but still need clarification if named people are copyright holders or contributors without copyright claim.
src/parsers/plan2/holidayscannerplan.cpp | ||
---|---|---|
1297–1301 ↗ | (On Diff #75594) | @winterz same question here as above: are these people copyright holders or file contributors? |
src/parsers/qcalendarsystem.cpp | ||
833 ↗ | (On Diff #75594) | I did them intense code-digging and found the source of this snippet |
Did additional code digging in the Plan repository and I think that all stated copyright claims are valid.
src/parsers/plan2/holidayparserdriverplan.cpp | ||
---|---|---|
6–13 ↗ | (On Diff #75594) | the original code comes from Plan's holiday.c
|
src/parsers/plan2/holidayparserplan.ypp | ||
3–10 ↗ | (On Diff #75594) | analyzed code history:
|
src/parsers/plan2/holidayscannerplan.cpp | ||
1297–1301 ↗ | (On Diff #75594) | this copyright statement comes from the .lpp file; thus to be discussed in that statement |
src/parsers/plan2/holidayscannerplan.lpp | ||
2–3 ↗ | (On Diff #75594) | analyzed the code history of this file:
|