KHolidays: Convert license statements to SPDX expressions
Needs ReviewPublic

Authored by cordlandwehr on Thu, Feb 13, 11:32 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Maniphest Tasks
T11550: Add SPDX License markers
Summary

Convert license statements to SPDX markers and
add license files as required by REUSE specification.

Diff Detail

Repository
R175 KHolidays
Branch
spdx
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22511
Build 22529: arc lint + arc unit
cordlandwehr created this revision.Thu, Feb 13, 11:32 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptThu, Feb 13, 11:32 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cordlandwehr requested review of this revision.Thu, Feb 13, 11:32 AM
cgiboudeaux added inline comments.
src/holidayregion.cpp
30

I don't think it should be changed here

src/lunarphase.cpp
6

This looks suspicious

@winterz ?

src/parsers/plan2/holidayparserdriverplan.cpp
5–19

The original text lacks clarity. Are these file contributors or copyright holders? @winterz

21

why is "by" needed here?

src/parsers/plan2/holidayparserplan.ypp
3–10

same question for this file

src/parsers/plan2/holidayscannerplan.cpp
1297–1301

and these lines were not updated

src/parsers/qcalendarsystem.cpp
831–832

also looks wrong

Clarified several statements

  • Recovered origin of weekNumber method and its original license
  • Unified verbose license statements
  • Clarified snippet licensing
cordlandwehr marked 5 inline comments as done.Sat, Feb 15, 9:54 AM

Updated several statements, but still need clarification if named people are copyright holders or contributors without copyright claim.

src/parsers/plan2/holidayscannerplan.cpp
1297–1301

@winterz same question here as above: are these people copyright holders or file contributors?

src/parsers/qcalendarsystem.cpp
831–832

I did them intense code-digging and found the source of this snippet

cordlandwehr marked 2 inline comments as done.

Make snippet copyright statement more verbose

looks ok to me.

src/lunarphase.cpp
6

no, it's fine.