POC: Make kstatusnotifieritem available without dbus
Needs ReviewPublic

Authored by vonreth on Wed, Feb 12, 9:26 PM.

Details

Reviewers
bcooksley
jjazeix
Summary

Well yes that extremely ugly and some real refactoring would be needed....

Diff Detail

Repository
R289 KNotifications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22418
Build 22436: arc lint + arc unit
vonreth created this revision.Wed, Feb 12, 9:26 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptWed, Feb 12, 9:26 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vonreth requested review of this revision.Wed, Feb 12, 9:26 PM
vonreth retitled this revision from Make kstatusnotifieritem available without dbus to POC: Make kstatusnotifieritem available without dbus.Wed, Feb 12, 9:28 PM
vonreth edited the summary of this revision. (Show Details)
vonreth added reviewers: bcooksley, jjazeix.

While preparing this I discovered that we should also review the locations where if MAC is used, as thats not the only platform that should use the systray icon

bcooksley added inline comments.Thu, Feb 13, 6:45 AM
src/kstatusnotifieritem.cpp
48

New header?

617

Won't this mean that showMessage() is a no-op on Windows systems without D-Bus?
I would have thought that systemTrayIcon->showMessage() should be used here as well?

888

From my reading of the setLegacySystemTrayEnabled() won't setting it to false explicitly disable any form of system tray icon?

jjazeix added a comment.EditedThu, Feb 13, 7:37 AM

thank you!
I did the same but way worse.
I think we can at least push this fix to remove all failing jobs then clean it up? This should fix half the failing jobs.

CMakeLists.txt
94

this is not the aim of this diff, but I looked at the code, I found this line was duplicated from line 43