improve some previously recycled strings
ClosedPublic

Authored by sitter on Tue, Feb 11, 3:50 PM.

Details

Summary

for 5.18 we recycled these to reduce the new strings, for 5.19 we want
something more approachable

Test Plan

fancy new strings show up

Diff Detail

Repository
R102 KInfoCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Tue, Feb 11, 3:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Feb 11, 3:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Tue, Feb 11, 3:50 PM

I do wonder if "Mounted Shares" is all that grand. Technically they may not be mounted but mountable. E.g. when you put a mount into /etc/fstab it will be listed here but not necessarily mounted.

Another question is if someone has better suggestions for the column names on the that table.

Resource | Mounted Under | Accessible

Resource in particular is a bit meh, it'd be the windows share name that was mounted so I am not sure there's a better label for it e.g. \\ajax.local\Public.

"Accessed shares"?

That may be misleading expectations I fear. When you browse smb:// in dolphin you'd be accessing shares, but they'd not appear in that list ;)

ngraham accepted this revision.Tue, Feb 11, 3:58 PM

In that case, with kio-fuse, "Mounted shares" is probably more accurate and just fine.

This revision is now accepted and ready to land.Tue, Feb 11, 3:58 PM
This revision was automatically updated to reflect the committed changes.