Differential D2730

[Task Manager] Use Qt.binding for prefix
ClosedPublic
Actions

Authored by broulik on Sep 9 2016, 2:34 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:c0f7ba8504d3: [Task Manager] Use Qt.binding for prefix
Summary

Bind prefix directly and onRepaintNeeded assign it a new Qt.binding.
This lets QML re-evaluate the binding when plasmoid.location (referenced in the taskPrefix JS function) changes.

Test Plan

Moved panel around, task graphics updated immediately.
Changed theme, task graphics updated immediately.

Hovered items before, inbetween, and after the above, worked just fine.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 6604.Sep 9 2016, 2:34 PM
broulik retitled this revision from to [Task Manager] Use Qt.binding for prefix.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 9 2016, 2:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Sep 19 2016, 10:31 AM
hein added a reviewer: hein.
This revision is now accepted and ready to land.Sep 19 2016, 10:31 AM
Closed by commit R119:c0f7ba8504d3: [Task Manager] Use Qt.binding for prefix (authored by broulik). · Explain WhySep 26 2016, 2:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6923

View Options

applets/taskmanager/package/contents/ui/Task.qml

Loading...