Differential D27303

[applets/taskmanager] Add a bit more padding around album/artist info in tooltip
ClosedPublic
Actions

Authored by ngraham on Feb 10 2020, 8:50 PM.

Details

Reviewers
manueljlin
filipf
Group Reviewers
VDG
Maniphest Tasks
T12640: Refine Task Manager tooltips
Commits
R119:7a0c4f86530f: [applets/taskmanager] Add a bit more padding around album/artist info in tooltip
Summary

Last visual change required to complete T12640: Refine Task Manager tooltips.

Test Plan

Before:


After:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Feb 10 2020, 8:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 10 2020, 8:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 10 2020, 8:50 PM
filipf added a subscriber: filipf.Feb 10 2020, 9:47 PM

The added vertical padding looks good to me, but I don't like how the horizontal paddding now makes these labels no longer aligned with the tooltip heading.

ngraham updated this revision to Diff 75425.Feb 11 2020, 1:07 AM

Only add vertical padding

ngraham edited the test plan for this revision. (Show Details)Feb 11 2020, 1:07 AM
filipf accepted this revision.Feb 11 2020, 7:18 AM
This revision is now accepted and ready to land.Feb 11 2020, 7:18 AM
Closed by commit R119:7a0c4f86530f: [applets/taskmanager] Add a bit more padding around album/artist info in tooltip (authored by ngraham). · Explain WhyFeb 11 2020, 2:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75473

View Options

applets/taskmanager/package/contents/ui/ToolTipInstance.qml

Loading...