Differential D27296

[PlasmaComponents]Clean up ListItem code
ClosedPublic
Actions

Authored by gvgeo on Feb 10 2020, 5:32 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R242:10c112fccda8: [PlasmaComponents]Clean up ListItem code
Summary

Removed two unused lines.
Removed old comments.
Minor style changes to comments.

Test Plan

Everything must stay unchanged visually and function wise for ListItems.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gvgeo created this revision.Feb 10 2020, 5:32 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 10 2020, 5:32 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
gvgeo requested review of this revision.Feb 10 2020, 5:32 PM
gvgeo added a comment.Feb 19 2020, 12:08 PM

The 2 removed lines were leftovers from 54e87fe879ba.

ngraham accepted this revision.Feb 19 2020, 3:44 PM
This revision is now accepted and ready to land.Feb 19 2020, 3:44 PM
Closed by commit R242:10c112fccda8: [PlasmaComponents]Clean up ListItem code (authored by gvgeo). · Explain WhyFeb 25 2020, 7:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76411

View Options

src/declarativeimports/plasmacomponents/qml/ListItem.qml

Loading...