Differential D2726

Make kpackage_install_package work with KDE_INSTALL_DIRS_NO_DEPRECATED
ClosedPublic
Actions

Authored by kossebau on Sep 9 2016, 12:58 PM.

Details

Reviewers
apol
mart
Group Reviewers
Plasma
Commits
R290:cf70d380d7a9: Make kpackage_install_package work with KDE_INSTALL_DIRS_NO_DEPRECATED
Summary

Currently kpackage_install_package fails if KDE_INSTALL_DIRS_NO_DEPRECATED
is set to TRUE, because the macro is still using the deprecated var
DATA_INSTALL_DIR
It should be fine to bump the min version of ECM required to needed ECM 1.6.0,
as someone using KF5 5.27 very surely also has a similar recent ECM.
(Compare also recent similar patch for KF5PackageMacros.cmake)

Also done (will be separate commits)

  • remove unused variable KPACKAGE_DATA_INSTALL_DIR
  • fix api dox for default value of install_dir

Diff Detail

Branch
supportKDE_INSTALL_DIRS_NO_DEPRECATED
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau updated this revision to Diff 6597.Sep 9 2016, 12:58 PM
kossebau retitled this revision from to Make kpackage_install_package work with KDE_INSTALL_DIRS_NO_DEPRECATED.
kossebau updated this object.
kossebau added reviewers: Plasma, mart, apol.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 9 2016, 12:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Sep 9 2016, 1:22 PM
mart edited edge metadata.
This revision is now accepted and ready to land.Sep 9 2016, 1:22 PM

Revision Contents
Changeset List

PathPackages
MKF5PackageMacros.cmake (9 lines)

Diff 6597

View Options

KF5PackageMacros.cmake

Loading...