Make the resource location configurable
AbandonedPublic

Authored by rempt on Sep 9 2016, 12:22 PM.

Details

Summary

Makes it possible to define a custom location for the user's resources.
If the custom location is empty, the default is used.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rempt updated this revision to Diff 6590.Sep 9 2016, 12:22 PM
rempt retitled this revision from to Make the resource location configurable.
rempt updated this object.
This revision was automatically updated to reflect the committed changes.
dkazakov reopened this revision.Sep 12 2016, 9:37 AM
dkazakov edited edge metadata.

I guess it is still open :)

dkazakov requested changes to this revision.Sep 12 2016, 9:49 AM
dkazakov edited edge metadata.

Ok, so the crash is fixed now. There are two small problems though:

  1. When there is no path override is set, then the line between the label and a button shows nothing. The user would expect seeing the default path for the resources here. At first I couldn't even find this option, because it is basically an empty space :)

  1. Pressing "Cancel" in the folder selection dialog resets the custom resources patch. This is really a bug.
    1. Select any folder as a resource path
    2. Press ok in the folder selection dialog
    3. Now you see the patch in the label in the middle
    4. Start selecting the new path again, but press Cancel in the folder selection dialog
    5. The patch is reset instead of just being untouched. That is very unexpected behavior
  1. [BLOCKER] The new resources path is used only for saving resources, not for loading
    1. Set a new resource path
    2. Restart Krita
    3. Create new preset, save it, see it appeared in the custom resources folder
    4. Restart Krita
    5. All the resources are loaded from the old location :( Newly saved resource is not here anymore.
This revision now requires changes to proceed.Sep 12 2016, 9:49 AM
rempt abandoned this revision.Sep 7 2018, 12:54 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptSep 7 2018, 12:54 PM
Restricted Application added a project: Krita. · View Herald Transcript