Move accounts overview to the LHS
Needs RevisionPublic

Authored by olivierjg on Sat, Feb 8, 5:13 AM.

Details

Reviewers
dfaure
mlaurent
Summary

First step towards using an item view for the accounts overview.

Diff Detail

Repository
R865 Ruqola
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22206
Build 22224: arc lint + arc unit
olivierjg requested review of this revision.Sat, Feb 8, 5:13 AM
olivierjg created this revision.
mlaurent requested changes to this revision.Sat, Feb 8, 7:55 AM
mlaurent added inline comments.
src/widgets/misc/accountsoverviewwidget.cpp
200

it's not the same commit as removing class no ?

> 2 differents commit

207

accountNumberChanged is not enough ?
it's called when we add/remove account.
I tested when I add/remove accounts.

src/widgets/ruqolacentralwidget.cpp
41

I created a separate class for allowing to test it.
So if you move here you need to readd autotest
Thanks

src/widgets/ruqolamainwindow.cpp
91

So now that you removed mAccountOverviewWidget which class will use it ?

389

Another commit ?

This revision now requires changes to proceed.Sat, Feb 8, 7:55 AM
dfaure added inline comments.Sat, Feb 8, 9:27 AM
src/widgets/ruqolacentralwidget.cpp
48

Laurent: it's used here.

src/widgets/ruqolamainwindow.cpp
389

I think the idea here (using QPointer) was to fix https://blogs.kde.org/node/3919
With QScopedPointer (or the dialog on the stack, same thing) you can end up double-deleting the dialog.

mlaurent added inline comments.Sat, Feb 8, 12:48 PM
src/widgets/ruqolacentralwidget.cpp
48

Oh on top ? Could you create a screenshot please ?
(I prefere on statusbar. why on top ?)

Sorry, but indeed I prefer account in statusbar.
Splitter can be increase when we have account status changed or with different language

regards

dfaure added a comment.Sun, Feb 9, 9:31 AM

This looks like it will be jumpy indeed.
Maybe "just icons" like in RC+ is a better solution?
With an overlaid number for unread messages, but also overlay icons for "successfully logged in" and "connection/login failed". Or that part could just use the "disabled" mode of painting icons, possibly.

Is using an accounts overview item view in the top-left acceptable? I really don't want this in the statusbar.

src/widgets/misc/accountsoverviewwidget.cpp
200

Not about removing the class, about putting this widget in the TL

src/widgets/ruqolacentralwidget.cpp
48

I want this to be an item view, not buttons, this is a "usable intermediate state"

src/widgets/ruqolamainwindow.cpp
91

The central widget.

389

Ok, sounds like a job for WA_DeleteOnClose but I'll just minimize changes

389

Well, the removal applies to the accounts overview widget, but I changed too much indeed.