Differential D2721

bug fix: Krita crashes when user selects File > New
ClosedPublic
Actions

Authored by bruceoutdoors on Sep 9 2016, 8:55 AM.

Details

Reviewers
woltherav
rempt
Summary

problem: Krita crashes (segmentation fault) when user selects File > New

In the new image dialog UI file wdgnewimage.ui, there is a KisColorButton cmbColor that has 2 dynamic properties: color and defaultColor. These 2 properties are of type KoColor, but the UI file passes QColor when setting up the UI.

My solution was just to remove the dynamic properties from cmbColor from the form editor. A KoColor is passed on somewhere later on.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
bruceoutdoors updated this revision to Diff 6573.Sep 9 2016, 8:55 AM
bruceoutdoors retitled this revision from to bug fix: Krita crashes when user selects File > New.
bruceoutdoors updated this object.
bruceoutdoors edited the test plan for this revision. (Show Details)
bruceoutdoors set the repository for this revision to R37 Krita.
bruceoutdoors added a project: Krita.
Restricted Application added a subscriber: woltherav. · View Herald TranscriptSep 9 2016, 8:55 AM
bruceoutdoors added reviewers: woltherav, rempt.Sep 9 2016, 8:59 AM
bruceoutdoors updated this object.
woltherav accepted this revision.Sep 9 2016, 9:05 AM
woltherav edited edge metadata.

yes, this would be my best guess as well. Really strange qtcreator left those :/

This revision is now accepted and ready to land.Sep 9 2016, 9:05 AM
rempt edited edge metadata.Sep 9 2016, 9:12 AM

See also bug 368483

bruceoutdoors added a comment.Sep 9 2016, 9:21 AM

Owh. Didn't realize someone submitted a bug report on that today. It's fixed as fast as it is announced!

aacid closed this revision.Feb 26 2017, 11:26 PM

Revision Contents
Changeset List

PathPackages
Mlibs/ui/forms/wdgnewimage.ui (42 lines)

Diff 6573

View Options

libs/ui/forms/wdgnewimage.ui

Loading...