Support services on flatpak
ClosedPublic

Authored by apol on Feb 7 2020, 12:07 PM.

Details

Summary

We have special casing for flatpak and Kate is mimicking KDBusService
only to some extent. This change helps kate support multiple flatpak instances
as well.

Test Plan

Built and made it work locally

Diff Detail

Repository
R40 Kate
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22168
Build 22186: arc lint + arc unit
apol created this revision.Feb 7 2020, 12:07 PM
Restricted Application added a project: Kate. · View Herald TranscriptFeb 7 2020, 12:07 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
apol requested review of this revision.Feb 7 2020, 12:07 PM
aacid added a subscriber: aacid.Feb 7 2020, 5:47 PM

I guess for future work, but would it make sense to try to move over to KDBusAddons?

What does the kate self-grown implementation provide that KDBusAddons doesn't?

cullmann accepted this revision.Feb 8 2020, 4:52 PM
cullmann added a subscriber: cullmann.

I guess I can trust you on the sandbox part ;=)
For Albert's question: We take a look which sessions are running in which Kate instances. If there would be a generic way to query all instances we could use this for that loop here.

This revision is now accepted and ready to land.Feb 8 2020, 4:52 PM
apol added a comment.Feb 13 2020, 2:30 PM

For Albert's question: We take a look which sessions are running in which Kate instances. If there would be a generic way to query all instances we could use this for that loop here.

Yes, ideally this code would move to KDBusAddons. In the end here it's defining logic that is mimicking what happens there.

apol closed this revision.Feb 13 2020, 2:32 PM