kcms/kwinoptions : convert Moving part to KConfigXT
ClosedPublic

Authored by meven on Feb 5 2020, 10:46 AM.

Details

Test Plan

Behavior unchanged

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Feb 5 2020, 10:46 AM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 5 2020, 10:46 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
meven requested review of this revision.Feb 5 2020, 10:46 AM
zzag added a subscriber: zzag.Feb 5 2020, 10:55 AM

Good stuff.

kcmkwin/kwinoptions/kwinoptions_settings.kcfg
14–24

<min/> and <max/> values are missing.

kcmkwin/kwinoptions/windows.cpp
505–506

Please don't commit commented code unless there is a reason, in which case the reason must be stated in a comment or something.

meven updated this revision to Diff 75045.Feb 5 2020, 12:41 PM
meven marked 2 inline comments as done.

Add min/max values in kcfg, clean unused const, clean comment

zzag accepted this revision.Feb 5 2020, 1:03 PM
zzag added inline comments.
kcmkwin/kwinoptions/windows.h
131

While you're on this, could you please rename it to m_config?

This revision is now accepted and ready to land.Feb 5 2020, 1:03 PM
zzag added inline comments.Feb 5 2020, 1:04 PM
kcmkwin/kwinoptions/CMakeLists.txt
19–22

Oh, please remove one empty line.

meven updated this revision to Diff 75050.Feb 5 2020, 2:02 PM
meven marked an inline comment as done.

Make KWinOptionsSettings use a singleton, rename to m_config, cleaning

meven marked an inline comment as done.Feb 5 2020, 2:03 PM
This revision was automatically updated to reflect the committed changes.